Skip to content

Commit

Permalink
build: use LC_ALL of C for maximum compatibility
Browse files Browse the repository at this point in the history
LC_ALL=en_US breaks on some systems (notably the SmartOS 16
configuration in our CI). Use LC_ALL=C instead.

PR-URL: nodejs#21222
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Jun 9, 2018
1 parent 400df22 commit 8551d31
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -672,10 +672,7 @@ def get_xcode_version(cc):
def get_gas_version(cc):
try:
custom_env = os.environ.copy()
# smartos (a.k.a. sunos5) does not have the en_US locale, and will give:
# `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument`
if 'sunos' not in sys.platform:
custom_env["LC_ALL"] = "en_US"
custom_env["LC_ALL"] = "C"
proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
'/dev/null', '-x',
'assembler', '/dev/null'],
Expand Down

0 comments on commit 8551d31

Please sign in to comment.