tile_pos_to_int_grid_with_grid_tiles_tile_maker checks grid_tiles #228
Conversation
| @@ -524,6 +524,7 @@ pub fn spawn_level( | |||
| tile_pos_to_tile_if_int_grid_nonzero_maker( | |||
| tile_pos_to_invisible_tile, | |||
| &layer_instance.int_grid_csv, | |||
| &grid_tiles, | |||
There was a problem hiding this comment.
So I'm a little confused by this actually - the issue is for grid_tiles overflow, right? I thought that could only happen on AutoTile layers (and intgrid+autotile layers). However, this change only affects non-autotile intgrid layers. The match tileset_definition { ... } this is inside of is Some on autotile intgrids, and None on non-autotile intgrids.
There was a problem hiding this comment.
Going back and looking at my LDTK file, the intgrid I'm using has the auto-layer tileset field set, so I guess it's intgrid+autotile. Maybe since the map is using that vs an autotile layer that points to an intgrid it's different? I'll try to get a small repro example set up since I'm admittedly not very familiar with LDTK.
|
Thanks for the detailed issue, and the contribution! |
A possible solution to #227, this PR changes
tile_pos_to_tile_if_int_grid_nonzero_makerto take in angrid_tilesarray as an argument and checks against it to see if an invisible tile should be made or not.