Upgrade to 0.30 SDK #327
Merged
Upgrade to 0.30 SDK #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 67.44% 66.23% -1.21%
==========================================
Files 56 61 +5
Lines 2559 2654 +95
==========================================
+ Hits 1726 1758 +32
- Misses 686 749 +63
Partials 147 147
Continue to review full report at Codecov.
|
shanev
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
utACK. Going to test locally before merging.
Nice job @jhernandezb!
| @@ -33,7 +34,7 @@ func TestInvalidStoryIdBackMsg(t *testing.T) { | |||
| msg := NewBackStoryMsg(invalidStoryID, validStake, validArgument, validCreator, validPeriod) | |||
| err := msg.ValidateBasic() | |||
|
|
|||
| assert.Equal(t, sdk.CodeType(702), err.Code(), err.Error()) | |||
| assert.Equal(t, story.CodeInvalidStoryID, err.Code(), err.Error()) | |||
There was a problem hiding this comment.
Much cleaner than the old way. Thank you.
| keyBacking: sdk.NewKVStoreKey("backings"), | ||
| keyBackingList: sdk.NewKVStoreKey("backingList"), | ||
| keyChallenge: sdk.NewKVStoreKey("challenges"), | ||
| keyStory: sdk.NewKVStoreKey(story.StoreKey), |
There was a problem hiding this comment.
Excellent. Stringly types be gone.
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func Test_NewUserEmptyPublicKey(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
Updates to dependencies
Breaking/notable changes in cosmos
x/staterenamed tox/stakingsee PRsdk.CodespaceTypeis now string (usually the name of the module is used) see PRStdSignatureno longer serializes AccountNumber and SequenceNumber see PRauth.Account: AccountNumber and SequenceNumber are nowuint64MountStoresIAVLtoMountStoressee PRgaid.tomlbut now they introducedSetMinGasPriceswhich is not included in v0.30 so left a TODO comment to update in future versions if needed/required see PRserver.DefaultAppInitis removed see PRpriv_validator_key.jsonandpriv_validator.json.bakboth added to gitignore