-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tribe's JoinButton to React #1123
Conversation
66ba1bf
to
07e816f
Compare
c594e80
to
eadc687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! And I tried it out too, all seemed to work:
- join joined me
- leave showed me the exact same model as in the live site, and made me leave...
- joining when logged out sent me to sign up with the tribe preselected
Just a few minor comments in there...
c5c33f9
to
41e12f5
Compare
- clarify variable names - fix propTypes - add comments
POST /api/users/memberships/:tribeId
41e12f5
to
fa91c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now :) Super!
@nicksellen Thank you for the reviews! |
Proposed Changes
Rewrite
JoinButton
to React.TODO
Testing Instructions
Part of #1133