Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tribe's JoinButton to React #1123

Merged
merged 7 commits into from
Dec 13, 2019
Merged

Migrate tribe's JoinButton to React #1123

merged 7 commits into from
Dec 13, 2019

Conversation

mrkvon
Copy link
Contributor

@mrkvon mrkvon commented Nov 14, 2019 •
edited
Loading

Proposed Changes

Rewrite JoinButton to React.

image

TODO

  • leave tribe popup
  • tooltip when Leave
  • update number of people in the tribe +-1 (better done later down the road)
  • google analytics (WONTDO)

Testing Instructions

  • see that everything works the same

Part of #1133

@mrkvon mrkvon force-pushed the tribes-react-join-button branch 2 times, most recently from 66ba1bf to 07e816f Compare November 27, 2019 00:50
@mrkvon mrkvon marked this pull request as ready for review November 27, 2019 01:04
nicksellen
nicksellen reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@nicksellen nicksellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And I tried it out too, all seemed to work:

  • join joined me
  • leave showed me the exact same model as in the live site, and made me leave...
  • joining when logged out sent me to sign up with the tribe preselected

Just a few minor comments in there...

modules/tribes/client/components/JoinButton.component.js Outdated Show resolved Hide resolved
modules/tribes/client/components/JoinButton.component.js Outdated Show resolved Hide resolved
modules/tribes/client/components/JoinButton.component.js Outdated Show resolved Hide resolved
nicksellen
nicksellen approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@nicksellen nicksellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now :) Super!

@mrkvon
Copy link
Contributor Author

mrkvon commented Dec 13, 2019

@nicksellen Thank you for the reviews!

@mrkvon mrkvon merged commit bc65dff into tribes-react Dec 13, 2019
@mrkvon mrkvon deleted the tribes-react-join-button branch December 13, 2019 20:06
mrkvon added a commit that referenced this pull request Jan 1, 2020
Migrate tribe's JoinButton to React (#1123)
2671c53 
as seen on /tribes page
mrkvon added a commit that referenced this pull request Jan 3, 2020
Migrate tribe's JoinButton to React (#1123)
0a1710a 
as seen on /tribes page
mrkvon added a commit that referenced this pull request Jan 3, 2020
Migrate tribe's JoinButton to React (#1123)
1bfc359 
as seen on /tribes page
mrkvon added a commit that referenced this pull request Jan 5, 2020
Migrate tribe's JoinButton to React (#1123)
60261e2 
as seen on /tribes page
mrkvon added a commit that referenced this pull request Jan 19, 2020
Migrate tribe's JoinButton to React (#1123)
ce4f4ff 
as seen on /tribes page
mrkvon added a commit that referenced this pull request Jan 20, 2020
Migrate tribe's JoinButton to React (#1123)
9abf9f9 
as seen on /tribes page
mrkvon added a commit that referenced this pull request Jan 20, 2020
Migrate tribe's JoinButton to React (#1123)
698c1d6 
as seen on /tribes page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksellen nicksellen nicksellen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrkvon @nicksellen