Migrate list of tribes to React #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkvon
force-pushed
the
tribes-react-list
branch
from
57b3671
to
49bf19e
Compare
mrkvon
force-pushed
the
tribes-react-list
branch
3 times, most recently
from
846b176
to
cfad678
Compare
nicksellen
reviewed
Dec 30, 2019
simison
reviewed
Dec 30, 2019
simison
reviewed
Dec 30, 2019
simison
reviewed
Dec 30, 2019
mrkvon
force-pushed
the
tribes-react-list
branch
from
cfad678
to
f314148
Compare
simison
approved these changes
Jan 2, 2020
mrkvon
force-pushed
the
tribes-react-list
branch
from
9fcdd0a
to
6f4b692
Compare
mrkvon
force-pushed
the
tribes-react-list
branch
from
6f4b692
to
3e0e3be
Compare
|
As far as I'm concerned, the review comments are resolved. Thank you for your feedback @nicksellen and @simison! If you like, have another look. Otherwise I'll merge to |
|
These are things good for follow up, but wanted to record some thoughts;
|
simison
approved these changes
Jan 4, 2020
added 4 commits
January 5, 2020 15:46
mrkvon
force-pushed
the
tribes-react-list
branch
from
8f13a62
to
9b52526
Compare
mrkvon
added a commit
that referenced
this pull request
Jan 5, 2020
+ introduce styled-components (https://www.styled-components.com/)
mrkvon
added a commit
that referenced
this pull request
Jan 19, 2020
+ introduce styled-components (https://www.styled-components.com/)
mrkvon
added a commit
that referenced
this pull request
Jan 20, 2020
+ introduce styled-components (https://www.styled-components.com/)
mrkvon
added a commit
that referenced
this pull request
Jan 20, 2020
+ introduce styled-components (https://www.styled-components.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Migrate to React the following:
The angulargrid was replaced with custom css, using styled-components.
Testing Instructions
Especially check that the grid behaves more or less as expected.
Work on #1133
Depends on #1134 and #1135. It's really just the last commit. The dependencies should be merged to(done)tribes-reactbranch before reviewing of this starts.