🐛 Fixed infinite loops in setFeatureImageCaption for deleted posts
#21081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref ONC-335 - Adds a condition to check whether the record is deleted or if deleting is in progress before firing the `setFeatureImageCaption` function, which leads to infinite loops. - Adds tests. Managed to reproduce the issue using tests and then fixed it accordingly.
ronaldlangeveld
changed the title
ronaldlangeveld
changed the title
setFeatureImageCaption for deleted posts
vlavrynovych
added a commit
to vlavrynovych/Ghost
that referenced
this pull request
Sep 25, 2024
* main: (411 commits) Shipped comments-ui@0.18.2 Fixed various visual details in Comments UI (TryGhost#21121) Shipped comments-ui@0.18.1 Update dependency mysql2 to v3.11.3 [SECURITY] Added reply button to comment replies Update dependency mysql2 to v3.11.2 [SECURITY] Fixed flaky member expertise test Update dependency mysql2 to v3.11.1 [SECURITY] Increased parallelisation of Nx processes Update tiptap monorepo to v2.7.2 Fixed Article feature image not showing up in the feed Fixed requiring passing tests for canary builds Updated Nx to v19 🐛 Fixed infinite loops in `setFeatureImageCaption` for deleted posts (TryGhost#21081) Fixed versioning and npm visibility for internal apps Update dependency html-validate to v8.24.0 Implemented lazy loading for Inbox & Activities (TryGhost#21106) Added sentry logging to local revisions service for localStorage errors (TryGhost#21078) Added posts restore UI (TryGhost#21096) Fixed bounce rate on stats page (TryGhost#21097) ... # Conflicts: # ghost/i18n/locales/uk/comments.json # ghost/i18n/locales/uk/portal.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ONC-364
setFeatureImageCaption.