Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused bc_diff #485

Merged
merged 1 commit into from
Feb 5, 2024
Merged

remove unused bc_diff #485

merged 1 commit into from
Feb 5, 2024

Conversation

reuvenharrison
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (a2470e3) 83.75% compared to head (c452c68) 84.36%.
Report is 8 commits behind head on main.

Files Patch % Lines
internal/diff_flags.go 63.63% 16 Missing ⚠️
delta/endpoints.go 79.31% 4 Missing and 2 partials ⚠️
load/spec_info.go 76.92% 4 Missing and 2 partials ⚠️
internal/cmd_flags.go 88.57% 3 Missing and 1 partial ⚠️
delta/parameters.go 90.62% 2 Missing and 1 partial ⚠️
delta/schema.go 57.14% 2 Missing and 1 partial ⚠️
internal/delta.go 88.88% 2 Missing and 1 partial ⚠️
load/option.go 86.95% 2 Missing and 1 partial ⚠️
internal/changelog_flags.go 95.45% 2 Missing ⚠️
delta/delta.go 95.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   83.75%   84.36%   +0.60%     
==========================================
  Files         217      227      +10     
  Lines       12593    12839     +246     
==========================================
+ Hits        10547    10831     +284     
+ Misses       1668     1628      -40     
- Partials      378      380       +2     
Flag Coverage Δ
unittests 84.36% <89.16%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison reopened this Feb 5, 2024
@reuvenharrison reuvenharrison merged commit a31fd62 into main Feb 5, 2024
12 of 15 checks passed
@reuvenharrison reuvenharrison deleted the remove-unused-bc_diff branch February 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants