Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not download a specific tumblr anymore #101

Closed
HydroHydro opened this issue Nov 14, 2020 · 9 comments
Closed

Can not download a specific tumblr anymore #101

HydroHydro opened this issue Nov 14, 2020 · 9 comments
Assignees
@arrowsmith001
Labels
beginner Estimated level of difficulty bug Something isn't working first-timers-only an easy issue for first time contributors only good first issue Good for newcomers

Comments

@HydroHydro
Copy link

HydroHydro commented Nov 14, 2020 •
edited
Loading

Describe the bug
This tumblr used to work a few months ago: https://protobacillus.tumblr.com/
But now it fails.

To Reproduce
Steps to reproduce the behavior:

  1. Add https://protobacillus.tumblr.com/
  2. Try to Crawl.
  3. Nothing happens.

Expected behavior
It should start downloading.

Desktop (please complete the following information):

  • TumblThree version: 1.0.11.12
  • OS: Windows 10
  • Browser: Chrome
  • Version [e.g. 22]

Additional context
Alternative URL: https://www.protobacillus.com/
Also doesn't work anymore.
@thomas694
Copy link
Contributor

Thanks for your bug report and providing an example url. At least it should be possible to add the blog by using the tumblr subdomain.

@thomas694 thomas694 added beginner Estimated level of difficulty bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Nov 15, 2020
@thomas694
Copy link
Contributor

thomas694 commented Nov 15, 2020 •
edited
Loading

As before this one is for first-timers-only. That means that we will only accept a PR for this one from someone who's never contributed to open source before. This one is particularly easy (but don't make that statement make you feel bad if you have a hard time with it, there's more to contributing to open source than changing lines of code, especially if it's your first time). We walk you through it if you need help. :-) Here are the steps to get a PR merged here (see also our guide).

  • Create a fork of the repository
  • Clone it to your local disk and create a new branch (e.g. 101-fix-blog-download-problem)
  • Build the app and run it in debug mode of VS
  • Set a breakpoint in line 114 of TumblrBlogCrawler.cs
  • Try to add the above blog (with its tumblr url), step through the code and find the problem
  • You should come to the conclusion that the problem has to do with line 149 in WebRequestFactory.cs and line 125 in AbstractCrawler.cs. What exactly is the problem? For this blog another kind of redirect is requested in the response header.
  • What has to be done to solve the problem? Does the solution also solve it for the other crawlers?
  • Commit your changes mentioning "issue Can not download a specific tumblr anymore #101" in the commit message
  • Push your changes to your fork, create a PR, get merged, celebrate ??

We are happy to support you if you need help.

@thomas694 thomas694 added first-timers-only an easy issue for first time contributors only and removed help wanted Extra attention is needed labels Nov 15, 2020
@thomas694 thomas694 mentioned this issue Nov 23, 2020
Closed
@xinwhyi
Copy link

xinwhyi commented Dec 6, 2020

Hello, first timer here. May I try fix this issue?

@thomas694
Copy link
Contributor

Hello,
thanks for your interest. Yes, you can work on that issue. I'll assign it to you.
If you have a question or get stuck, feel free to ask.

@xinwhyi
Copy link

xinwhyi commented Dec 7, 2020

VS prompts the project can only run on VS Windows, does that sound right? If so, I'm afraid I can't take this issue :(

@thomas694
Copy link
Contributor

Yes, TumblThree is a Windows application. That's no problem, I'll unassign the issue.
So this issue is free for someone else.

@arrowsmith001
Copy link
Contributor

Hi, I would like to have a go at this issue.

@thomas694
Copy link
Contributor

Ok, here you go.

@arrowsmith001 arrowsmith001 mentioned this issue Mar 21, 2021
Merged
thomas694 pushed a commit that referenced this issue Mar 23, 2021
@arrowsmith001
Add issue #101 "Can not download a specific tumblr anymore" (PR #132)
c865f3a 
- blogs using their own domain weren't downloadable any more
@thomas694
Copy link
Contributor

Thank you for your first contribution and PR to our TumblThree project.
Your PR has been merged and you've been added to our list of contributors.
We would be happy to receive more contributions from you in the future. Maybe you can help us with one or the other issue.

thomas694 added a commit that referenced this issue Apr 1, 2021
@thomas694
Add issue #101 "Can not download a specific tumblr anymore"
08d2ace 
- Due to the last fix it is now possible again to add blogs with custom domain by using its tumblr url. So the redirect is caught and the blog is updated with the new url.
- Now it is also possible to add these blogs with custom domain directly through the 'add blog' field. The entered url is downloaded and checked for tumblr critera and if found, the blog is added to the list.
- The clipboard monitor has not been adapted. It shall not check all url-like texts, only explicit tumblr urls.
@thomas694 thomas694 mentioned this issue Apr 2, 2021
Closed
@thomas694 thomas694 mentioned this issue Nov 20, 2021
Open
@thomas694 thomas694 mentioned this issue May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arrowsmith001 arrowsmith001

Labels
beginner Estimated level of difficulty bug Something isn't working first-timers-only an easy issue for first time contributors only good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HydroHydro @arrowsmith001 @thomas694 @xinwhyi