-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to authenticate with Tumblr #349
Comments
Thanks for looking to find the error. "isLoggedIn": {
"isPartiallyRegistered": false,
"isLoggedIn": false,
"isAdmin": null
}, So either the login didn't work properly, but then you shouldn't be able to navigate to your account page in the popup, or the cookies extraction after closing the popup failed. I assume the latter. |
The cookies call returns this (CSV format):
|
I looked at line 280 of
|
That are the correct cookies. And yet, when requesting the account settings page in If you comment out line 81 in |
Yes, that did it. I'll try to see what the difference is between the two collections. |
Well, a few days of digging and debugging haven't turned anything up. My best guess is some bug in CookieContainer is maybe not sending cookies for subdomains when it should, or something. |
Thanks for taking the time and looking at it. I think, then we use two different ways depending on the platform being accessed. |
- The "new" style of cookie extraction didn't work for the newTumbl authentication, so the old way was used. As it also worked with Tumblr, it was kept. But it looks like some users are then unable to log in to Tumblr. - So we do now two different ways of cookie extraction.
The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed. |
Describe the bug
When doing a Tumblr authentication, after logging in successfully and closing the popup, the UI does not indicate that login has succeeded. Any blogs that require authentication continue to say so.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect the UI to change to say "Logged in as XXX" and for blogs that require authentication to work.
Screenshots
Desktop (please complete the following information):
Additional context
I ran the app from the source code and traced the error to line 328 of
LoginService.cs
, called from line 1147 inSettingsViewModel.cs
. The variable is null, which it returns, and thus the subsequent check for "are you logged in" fails.This is what the
___INITIAL_STATE___
value looks like in the returned document (some tokens redacted):And this is the full page content, including the above:
Based on the headers in the HTML, it looks like the code is expecting the page to have automatically redirected to the
/settings/account
page, which does contain the expectedemail
value in the response. However manually navigating to this page in the popup before closing it did not produce the expected behaviour.The text was updated successfully, but these errors were encountered: