Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JsonConverter to handle fields being a single or array instance. #582

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mjharwood
Copy link
Contributor

TumblrSearchJson does the same thing (the objects are identical except for one field)

refs #579

Checklist

Confirm you have completed the following actions prior to submitting this PR.

  • There is an existing issue report for this PR.
  • I have forked this project.
  • I have created a feature branch.
  • My changes have been committed.
  • I have pushed my changes to the branch.

Title

Fix issue with TumblrTagSearch not handling arrays of some objects

Issue Resolution

This Pull Request Fixes #579

TumblrSearchJson does the same thing (the objects are identical except for one field)

refs TumblThreeApp#579
@thomas694 thomas694 merged commit 548c35b into TumblThreeApp:master Oct 31, 2024
1 check passed
@thomas694
Copy link
Contributor

Thanks for your PR.
Your PR has been merged and you've been added to our list of contributors.
You are welcome to solve more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tumblr sometimes returns an empty json array for Attribution rather than an object
2 participants