Use modern intellij-platform-plugin-template #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stukalin
commented
Aug 13, 2021
| // Kotlin support | ||
| id("org.jetbrains.kotlin.jvm") version "1.5.10" | ||
| // gradle-intellij-plugin - read more: https://github.com/JetBrains/gradle-intellij-plugin | ||
| id("org.jetbrains.intellij") version "1.0" |
There was a problem hiding this comment.
I haven't upgraded it here to the latest version yet but it's still an upgrade to v1.0.
And there are some deprecations in v1.1.4 which I wanna address first.
There was a problem hiding this comment.
@stukalin any pointers on what the next steps are?
- update the plugin to the latest version
- update the IntelliJ version
- release the plugin
like that? 😅
|
Thanks! I'm currently on vacation but I'll have a look once I'm back next week. |
Turbo87
force-pushed
the
use-modern-template
branch
from
f6f527f
to
72852f6
Compare
|
I've rebased and slightly adjusted it. Thanks a lot for this!! :) |
|
Correct! Now it's my turn to be on holidays. Will push the next pr on Fri.
ср, 18 авг. 2021 г., 14:35 Tobias Bieniek ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In build.gradle.kts
<#384 (comment)>
:
> @@ -0,0 +1,62 @@
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
+
+fun properties(key: String) = project.findProperty(key).toString()
+
+plugins {
+ // Java support
+ id("java")
+ // Kotlin support
+ id("org.jetbrains.kotlin.jvm") version "1.5.10"
+ // gradle-intellij-plugin - read more: https://github.com/JetBrains/gradle-intellij-plugin
+ id("org.jetbrains.intellij") version "1.0"
@stukalin <https://github.com/stukalin> any pointers on what the next
steps are?
- update the plugin to the latest version
- update the IntelliJ version
- release the plugin
like that? 😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#384 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLIBRPPD6RKG3KRDDFSKQTT5OLHVANCNFSM5CC5GYIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
awesome, thanks
enjoy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to bump the plugin version to 2021.2 and it wasn't straightforward for me because I had to upgrade the
gradle-intellij-pluginto the latest version due to the JetBrains/intellij-platform-gradle-plugin#674 and it required to upgrade gradle and this whole thing didn't work anyhow.So I ended up grabbing the latest intellij-platform-plugin-template and adjusting it so that it basically has the same settings as we used to have.
The IDE version bump PR comes after this one is accepted