Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionallity #6

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

TetzkatLipHoka
Copy link

Added Sin/Cos/Exp/Ln
Added To*String

Added Sin/Cos/Exp/Ln
SHL overload for BigInteger
SinCos, ArcTan2, Tan
ArcTan
Fixed Ln loosing frac of initial float
Removed debug-rounds
@jimmckeeth
Copy link

You need to remove the DCU file and I would like to see some unit tests.

@TetzkatLipHoka
Copy link
Author

Uploaded DCU after last bigger Update 😓
Merged latest changes and uploaded the proper file.
Didn't create test cases when developing as I used it for a Calculator supporting regular- and big-types - Just eye-balled the results to be equal for both types.
Also have no clue how DUnit Testing works tbh.

image
image

@jimmckeeth
Copy link

I did a quick test of the sin function vs the Windows calculator.
Sin(1)
0.8414709848078965066525023216303
but the function returns
0.8414709848771047991823601743884
which only has a few digits of accuracy. Running the System.Math function returns
0.8414709848078965066645908132958
with MORE accuracy than your implementation

Looking at your function you are using some constants like 1.27323954473516

Which is probably introducing the inaccuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants