Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vncviewer: exception on setting apply #49

Closed
Ri0n opened this issue Aug 11, 2016 · 2 comments
Closed

vncviewer: exception on setting apply #49

Ri0n opened this issue Aug 11, 2016 · 2 comments
Labels
bug fixed

Comments

@Ri0n
Copy link

Ri0n commented Aug 11, 2016 

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
        at com.turbovnc.vncviewer.CConn.getOptions(CConn.java:1548)
        at com.turbovnc.vncviewer.OptionsDialog.actionPerformed(OptionsDialog.java:789)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)

Java: java-1.8.0-openjdk-amd64
@dcommander
Copy link
Member

I tried to reproduce this under Ubuntu 16.04 and CentOS 7 using OpenJDK 1.8.0, and unfortunately I can't. Can you provide any additional details? The specific error is curious, because it doesn't appear from looking at the code that such an error should ever be possible at that location.

@Ri0n
Copy link
Author

Ri0n commented Sep 7, 2016

Just close this bug. I have not time to retest it.

dcommander added a commit that referenced this issue Sep 21, 2016
@dcommander
Java: Fix another NPE when dismissing Options dlg
4336781 
<sigh> This is why we can't have nice things.

9d6a396 (exposing keyboarding grabbing
in the GUI) contained a logic error.  Because the || wasn't contained
within parantheses, the last condition-- which dereferenced viewport--
was evaluated even if viewport==null.  No bueno.

Fixes #49
Fixes #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ri0n @dcommander