Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Extension: Mouse Speed. #1715

Open
wants to merge 92 commits into
base: master
Choose a base branch
from

Conversation

hammouda101010
Copy link

Mouse Speed is an extension that can get the speed of the mouse

@SharkPool-SP
Copy link
Collaborator

SharkPool-SP commented Oct 9, 2024

this could honeslty just be added as a new block to Sensing+, or any of the mouse extensions

@CubesterYT
Copy link
Collaborator

Definitely not Sensing+ at this time, it's already bloated enough.

@hammouda101010
Copy link
Author

this could honeslty just be added as a new block to Sensing+, or any of the mouse extensions

that was what i was thinking!

@David-Orangemoon
Copy link
Contributor

Definitely not Sensing+ at this time, it's already bloated enough.

I think sensing + should just be hidden and deprecated.

@hammouda101010
Copy link
Author

Definitely not Sensing+ at this time, it's already bloated enough.

I think sensing + should just be hidden and deprecated.

how about you rewrite it, its not THAT hard.

@David-Orangemoon
Copy link
Contributor

Definitely not Sensing+ at this time, it's already bloated enough.

I think sensing + should just be hidden and deprecated.

how about you rewrite it, its not THAT hard.

It was a bloated extension that should be replaced with other smaller extensions like multi touch, and a dedicated gyro extension.

@snowboyz0825
Copy link

I feel as though this is just bloat - you could code something that finds the mouse speed pretty easily, it would really only save ~5-10 blocks if coded well.

@hammouda101010
Copy link
Author

I feel as though this is just bloat - you could code something that finds the mouse speed pretty easily, it would really only save ~5-10 blocks if coded well.

well i tried to add more blocks so it doesnt looks like $h!11y bloat.

@unknown07724
Copy link

yes

@David-Orangemoon
Copy link
Contributor

dang, its been a while

At least you hopefully won't have to wait 1/2 year for yours to get merged.

@hammouda101010
Copy link
Author

please @GarboMuffin review this PR 😭

@CST1229
Copy link
Collaborator

CST1229 commented Oct 28, 2024

please keep it to one extension per pull request. you can use branches in git to separate your extensions, and ideally your master branch should be left unmodified (as a base for your other branches)

@hammouda101010
Copy link
Author

hammouda101010 commented Oct 28, 2024

please keep it to one extension per pull request. you can use branches in git to separate your extensions, and ideally your master branch should be left unmodified (as a base for your other branches)

well i modified the main branch lol but atleast it has only one extension this time. also created a default branch

@hammouda101010
Copy link
Author

calling reviewers @CubesterYT @CST1229

@hammouda101010
Copy link
Author

hammouda101010 commented Oct 28, 2024

seriously, will this will never be reviewed for the sake of @GarboMuffin ?

@Brackets-Coder
Copy link

Brackets-Coder commented Oct 29, 2024

seriously, will this will never be reviewed for the sake of @GarboMuffin ?

Patience, young Padawan. Your extension will be reviewed in time.

As of now, I'm pretty sure the repository merging format has been changed so that any PR that has been approved by two people with write access will be automatically merged into the main branch. It looks like you don't have any reviews yet. As of now, I think this includes CST1229, CubesterYT, SharkPool-SP, DNin01, and of course GarboMuffin.

Just be patient. This repository is notoriously slow...

@hammouda101010
Copy link
Author

seriously, will this will never be reviewed for the sake of @GarboMuffin ?

Patience, young Padawan. Your extension will be reviewed in time.

As of now, I'm pretty sure the repository merging format has been changed so that any PR that has been approved by two people with write access will be automatically merged into the main branch. It looks like you don't have any reviews yet. As of now, I think this includes CST1229, CubesterYT, SharkPool-SP, DNin01, and of course GarboMuffin.

Just be patient. This repository is notoriously slow...

you're kidding me this will take a month for a reviewer to view this PR

Copy link

@unknown07724 unknown07724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thing

@hammouda101010
Copy link
Author

they are conficts in the PR. can somebody fix them?

Copy link
Author

@hammouda101010 hammouda101010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything look fine

@CubesterYT
Copy link
Collaborator

you're kidding me this will take a month for a reviewer to view this PR

There are some PRs here that don't have reviews yet that are a year or two old, they haven't complained. Things take time, people have lives.

@hammouda101010
Copy link
Author

it's been so long 💀 @GarboMuffin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants