Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New format workflow #1770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

CubesterYT
Copy link
Collaborator

Add a new workflow that should format a PR when a message is "!format"

Further testing by others is needed.

@CubesterYT CubesterYT added the pr: other Pull requests that neither add new extensions or change existing ones label Nov 30, 2024
@SharkPool-SP SharkPool-SP self-requested a review December 1, 2024 00:25
@CST1229
Copy link
Collaborator

CST1229 commented Dec 11, 2024

I still think this should be a workflow_dispatch workflow, and not a comment-based one.

@CubesterYT
Copy link
Collaborator Author

Are workflow_dispatchs accessible by normal people?

@GarboMuffin
Copy link
Member

If they enable GitHub actions on their fork. Do they need to do that anyways for this to work?

@CubesterYT
Copy link
Collaborator Author

As it currently works, when the comment command is said, actions will auto format the PR, in theory. I haven't done extensive testing, so I'd like if others actually tried.

@CST1229
Copy link
Collaborator

CST1229 commented Dec 11, 2024

As it currently works, when the comment command is said, actions will auto format the PR, in theory. I haven't done extensive testing, so I'd like if others actually tried.

i don't think actions would allow committing on a user's branch without them enabling actions (see also: sa's autoformat action which i'm pretty sure you do have to enable actions for)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: other Pull requests that neither add new extensions or change existing ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants