Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lily/Video] add m3u8 support #1785

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[Lily/Video] add m3u8 support #1785

wants to merge 11 commits into from

Conversation

jexjws
Copy link

@jexjws jexjws commented Dec 11, 2024

  1. using hls.js to play m3u8
  2. bundled hls.js directly into the extension

Copy link
Author

@jexjws jexjws Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!(await Scratch.canFetch(url))) return;

WARNING : If the resource URLs in a .m3u8 file are not on the same domain as the .m3u8 file itself, the client can fetch resources from other domains without using Scratch.fetch.

@CubesterYT
Copy link
Collaborator

If you use an outside library, you must make an offline copy of it and imbibe it into the extension directly, and include the license of said library in the extension as well.

@jexjws
Copy link
Author

jexjws commented Dec 12, 2024

make an offline copy of it and imbibe it into the extension directly

  1. Why would we bundle hls.js directly into the extension? It seems unnecessary to add a 400KB overhead for handling non-M3U8 videos. Is this intended for offline usage?

  2. if we do this, when the upstream project releases important updates (such as security updates), we will need to manually update the hls.js within our repository. Manual updates can cause delays. Is there a way to solve this problem (for example, by having Dependabot manage the hls.js within extensions repository? I'm not familiar with Dependabot and wouldn't know how to set that up.)

and include the license of said library in the extension as well.

OK. I will do this.

Add hls.js license and usage information
@LilyMakesThings
Copy link
Contributor

  1. It's intended for offline usage and in the unlikely event it becomes inaccessible for whatever reason.
  2. If it works, what reason would there be to update in a timely manner? You'd be amazed how many dependencies for Scratch and by extension TurboWarp have not been updated in half a decade.

@jexjws
Copy link
Author

jexjws commented Dec 13, 2024

Addressed. Please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants