Use buble to prohibit ES6 code ending up in turf.min.js #2236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've been thinking about #2191 #2200 more extensively and realised the underlying problem is that as it stands we can't upgrade
rbush
to the latest version (and in turnconcaveman
which relies on it) directly because it is now an ES6 module. As more of the Node ecosystem moves to using ES6 this will become more and more common place and we can't keep relying on external deps (and there deps) to be written in ES5.I was attempting in #2225 to skirt around this by trying to use the ES5 export in
rbush
, but ultimately we can't do the same for concaveman because it uses the latest version ofrbush
, which eventually ends up inturf.min.js
.Here I was thinking we could run buble a minimal ES2015+ transpiler over the code that goes into
turf.min.js
to allow us to use any dependency we want inside our packages. Here I've bumped concaveman and rbush and you can see no ES6 code ends up inturf.min.js
because it gets transpiled (this wouldn't be possible without buble).What do you folks think?