Implemented azimuthToBearing

[basvdijk]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Have read How To Contribute.
• Run npm test at the sub modules where changes have occurred.
• Run npm run lint to ensure code style at the turf module level.

Submitting a new TurfJS Module.

• Overview description of proposed module.
• Include JSDocs with a basic example.
• Execute ./scripts/generate-readmes to create README.md.
• Add yourself to contributors in package.json using "Full Name <@github Username>".

[basvdijk]

Implemented #2399

[rowanwins]

👍 @basvdijk

[JamesLMilner]

I think we can merge this :)

[rowanwins]

Requires a tidyup of the function so that the tests pass

[rowanwins]

Pretty sure this isn't working as expected @basvdijk now that I've run CI and seen the failing tests.

[stebogit]

this works 😃:

function azimuthToBearing(angle) {
  angle = angle % 360;
  if (angle > 0) return angle > 180 ? angle - 360 : angle;
  return angle < -180 ? angle + 360 : angle;
}

test('azimuthToBearing', t => {
  t.equal(azimuthToBearing(0), 0);
  t.equal(azimuthToBearing(360), 0);
  t.equal(azimuthToBearing(180), 180);

  t.equal(azimuthToBearing(40), 40);
  t.equal(azimuthToBearing(40 + 360), 40);

  t.equal(azimuthToBearing(-35), -35);
  t.equal(azimuthToBearing(-35 - 360), -35);

  t.equal(azimuthToBearing(255), -105);
  t.equal(azimuthToBearing(255 + 360), -105);

  t.equal(azimuthToBearing(-200), 160);
  t.equal(azimuthToBearing(-200 - 360), 160);

  t.end();
});

[stebogit]

I think angle should not be restricted to 0-360, but any number, you can easily normalize it with mod 360

[stebogit]

this works 😃:

function azimuthToBearing(angle) {
  angle = angle % 360;
  if (angle > 0) return angle > 180 ? angle - 360 : angle;
  return angle < -180 ? angle + 360 : angle;
}

test('azimuthToBearing', t => {
  t.equal(azimuthToBearing(0), 0);
  t.equal(azimuthToBearing(360), 0);
  t.equal(azimuthToBearing(180), 180);

  t.equal(azimuthToBearing(40), 40);
  t.equal(azimuthToBearing(40 + 360), 40);

  t.equal(azimuthToBearing(-35), -35);
  t.equal(azimuthToBearing(-35 - 360), -35);

  t.equal(azimuthToBearing(255), -105);
  t.equal(azimuthToBearing(255 + 360), -105);

  t.equal(azimuthToBearing(-200), 160);
  t.equal(azimuthToBearing(-200 - 360), 160);

  t.end();
});

[mfedderly]

I'm open to merging this but can you update this branch and incorporate the suggestions from stebogit? Thanks!

[basvdijk]

@mfedderly just added the fixes according to comment of @stebogit

[mfedderly]

It looks like you picked up a merge conflict along the way can you knock that out too?

[basvdijk]

@mfedderly somehow I can't get it to work. I keep getting issues, merge conflicts and I am currently unable to make it work. I guess it has something to do with being 100 commits behind after a year.

[mfedderly]

It might have been that you just needed to pull from the turf repo instead of your fork? If you're just opening a new PR can you @ me so I see it? Thanks.

[basvdijk]

@mfedderly Created #2674 to replace this PR