Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #915 (booleanContains incorrect when checking 2 polygons) #917

Closed
wants to merge 1 commit into from

Conversation

stebogit
Copy link
Collaborator

@rowanwins take a look at this

@stebogit stebogit changed the title Fixes #915 Fixes #915 (booleanContains incorrect when checking 2 polygons) Aug 24, 2017
@stebogit
Copy link
Collaborator Author

😳 it fails!
I thought for..of was OK to replace the classic for loop; I guess it's not @DenisCarriere... 😞

screen shot 2017-08-24 at 9 23 25 am

Locally worked fine.

@rowanwins
Copy link
Member

Hey @stebogit

I'm happy to take this one over, I started taking a look at this last night and found a few other things which need fixing in the booleanContains. I'll post an issue with a bit of a discussion :)

@stebogit
Copy link
Collaborator Author

👍 I worked on it last night as well, just wanted to share what I produced 😄
Feel free to discard this if you want.

@DenisCarriere
Copy link
Member

@stebogit 👍 Nice stuff, I've been away at the cottage with horrible to no WiFi.

Yep for..of loops are not valid in ES5 (bummer 😢), maybe it might be worth converting the tests back to ES5+ (NodeJS 4 compatible) that way we can catch those types of errors quicker (just a thought).

@stebogit
Copy link
Collaborator Author

at the cottage with horrible to no WiFi.

Wouldn't be a genuine relaxing cottage with fancy hi-speed WiFi 😄

@DenisCarriere
Copy link
Member

DenisCarriere commented Aug 29, 2017

Wouldn't be a genuine relaxing cottage with fancy hi-speed WiFi

Waterfront properties tend to have poor Internet 😄 (the nicer the view, the slower the connection)

image

@rowanwins
Copy link
Member

Closed in favour of #923

@rowanwins rowanwins closed this Aug 29, 2017
@DenisCarriere DenisCarriere deleted the boolean-contains-fix branch September 5, 2017 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants