Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for AbstractString #397

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Better support for AbstractString #397

merged 3 commits into from
Jan 30, 2023

Conversation

devmotion
Copy link
Member

Fixes #396.

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 83.76% // Head: 83.76% // No change to project coverage 👍

Coverage data is based on head (2146275) compared to base (8c3f5ed).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          19       19           
  Lines        1035     1035           
=======================================
  Hits          867      867           
  Misses        168      168           
Impacted Files Coverage Δ
src/chains.jl 84.39% <57.14%> (ø)
src/utils.jl 95.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cpfiffer
Copy link
Member

Thanks!

@cpfiffer cpfiffer merged commit 711a298 into master Jan 30, 2023
@cpfiffer cpfiffer deleted the dw/abstractstring branch January 30, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow AbstractString to get parts of a Chain
2 participants