Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape regex in namesingroup properly #398

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Escape regex in namesingroup properly #398

merged 3 commits into from
Jan 30, 2023

Conversation

torfjelde
Copy link
Member

Adds proper escaping for indexing in namesingroup, hence adding support for stuff like chain[:, Symbol("A[1]"), :].

devmotion
devmotion reviewed Jan 30, 2023
View reviewed changes
src/chains.jl Outdated Show resolved Hide resolved
@torfjelde @devmotion
Update src/chains.jl
0bebafb 
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
devmotion
devmotion approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@torfjelde torfjelde merged commit 31521dd into master Jan 30, 2023
@torfjelde torfjelde deleted the torfjelde/bugfix branch January 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torfjelde @devmotion