Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for ADTypes 0.2 #2243

Merged
merged 1 commit into from
May 31, 2024
Merged

Drop support for ADTypes 0.2 #2243

merged 1 commit into from
May 31, 2024

Conversation

yebai
Copy link
Member

@yebai yebai commented May 30, 2024

ADTypes 0.2 doesn't support AutoTapir yet.

@yebai
Drop support for ADTypes 0.2
44c9a4c 
ADTypes 0.2 doesn't support AutoTapir yet.
torfjelde
torfjelde requested changes May 31, 2024
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. This doesn't really fix the issue though.

Even if we make a release now, whenever someone uses a package with ADTypes.jl v0.2, it will just install v0.32.2, which breaks. You need to pull the release @yebai

@yebai
Copy link
Member Author

yebai commented May 31, 2024

The standard approach for fixing a bug is through a new release instead of reversing a release, right?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9302197105

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 9301631361: 0.0%
Covered Lines: 0
Relevant Lines: 1529
💛 - Coveralls

@devmotion
Copy link
Member

The standard approach for fixing a bug is through a new release instead of reversing a release, right?

People seem to have quite diverse (and strong) opinions on this matter 😄 But some maintainers of the registry are definitely not happy about yanking releases. However, as stated in the README

There is however, a special category of bugged releases that can not be resolved by having a patch release. These also may to be resolved by yanking. That special category is when the compat bounds have been set too wide. i.e. say v2.10.0 was released using a feature not on julia v1.6 but the compat entry for julia was not raised in the release. In this case releasing a v2.10.1 with the corrected julia compat would not solve the issue as on julia v1.6 Pkg would still resolve the broken v2.10.0, and as a minor bump, reverting the code changes would not be valid in a patch bump. In this case one may either submit a PR to retroactively adjust the compat bounds of previous versions (best user-facing results, but slow and error-prone to implement) or yank the offending release.

@yebai
Copy link
Member Author

yebai commented May 31, 2024 •
edited
Loading

I wasn't aware of the yanked option, but it seems appropriate for this purpose. I created a PR:

JuliaRegistries/General#108024

@torfjelde
Copy link
Member

Great! Approving now then.

@torfjelde torfjelde merged commit e9fddbe into master May 31, 2024
11 checks passed
@torfjelde torfjelde deleted the bump-adtypes branch May 31, 2024 21:00
yebai added a commit that referenced this pull request Jun 3, 2024
@yebai @mhauru
@torfjelde @github-actions
Update Project.toml (#2244)
6a015a3 
* Update README.md

* Export adtype `AutoTapir` (#2236)

* Export adtype `AutoTapir`

* Update Project.toml

* Fix missing AutoTapir  (#2242)

* Update Essential.jl

* Update Project.toml

* Drop support for ADTypes 0.2 (#2243)

ADTypes 0.2 doesn't support AutoTapir yet.

* Optimization improvements (#2221)

* initial work on interface

* Improving the Optimization.jl interface, work in progress

* More work on Optimization.jl, still in progress

* Add docstrings to Optimisation.jl

* Fix OptimizationOptimJL version constraint

* Clean up optimisation TODO notes

* Relax OptimizationOptimJL version constraints

* Simplify optimization imports

* Remove commented out code

* Small improvements all over in optimisation

* Clean up of Optimisation tests

* Add a test for OptimizationBBO

* Add tests using OptimizationNLopt

* Rename/move the optimisation test files

The files for Optimisaton.jl and OptimInterface.jl were in the wrong
folders: One in `test/optimisation` the other in `test/ext`, but the
wrong way around.

* Relax compat bounds on OptimizationBBO and OptimizationNLopt

* Split a testset to test/optimisation/OptimisationCore.jl

* Import AbstractADType from ADTypes, not SciMLBase

* Fix Optimization.jl depwarning

* Fix seeds in more tests

* Merge OptimizationCore into Optimization

* In optimisation, rename init_value to initial_params

* Optimisation docstring improvements

* Code style adjustments in optimisation

* Qualify references in optimisation

* Simplify creation of ModeResults

* Qualified references in optimization tests

* Enforce line length in optimization

* Simplify optimisation exports

* Enforce line legth in Optim.jl interface

* Refactor away ModeEstimationProblem

* Style and docstring improvements for optimisation

* Add := test to optimisation tests.

* Clarify comment

* Simplify generate_initial_params

* Fix doc references

* Rename testsets

* Refactor check_success

* Make initial_params a kwarg

* Remove unnecessary type constrain on kwarg

* Fix broken reference in tests

* Fix bug in generate_initial_params

* Fix qualified references in optimisation tests

* Add hasstats checks to optimisation tests

* Extend OptimizationOptimJL compat to 0.3

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Change some `import`s to `using`

Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>

* Change <keyword arguments> to kwargs... in docstrings

* Add a two-argument method to OptimLogDensity as callable

---------

Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update Project.toml

* CompatHelper: bump compat for OptimizationOptimJL to 0.3 for package test, (keep existing compat) (#2246)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

---------

Co-authored-by: Markus Hauru <markus@mhauru.org>
Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
mhauru added a commit that referenced this pull request Jun 5, 2024
@mhauru @yebai
@torfjelde @github-actions
Test restructuring (#2237)
03d0e78 
* Remove unused test util function

* Refactoring ad and optiminterface tests to modules

* Add SelectiveTests.jl

* Rework tests CI GA

* Switch test CI on Mac back to x64

* Remove coverage from CI. Improve matrix.

* Wrap all tests in modules.

* Remove unused test utils

* Remove GA workflows for DynamicHMC and Numerical

* Rename TuringCI GA to Tests

* Fix test_args passing in CI

* Fix for CI test matrix

* Fixes to various test files

* Add container.jl to test suite

* Fix spacing around * in test includes

* Split ad.jl and abstractmcmc.jl tests to separate CI jobs

* Alphabetise imports in tests

* In tests, use import X over using X: X

* Add missing imports to abstractmcmc.jl tests

* Add some missing imports to tests

* Merge ad_utils.jl to ad.jl in tests

* Merge testing_functions.jl into mh.jl in tests

* Simplify test_utils

Turn all of them into modules or merge them into other files that used
to `include` them.

* Add missing import to numerical_tests.jl

* Update Project.toml (#2244)

* Update README.md

* Export adtype `AutoTapir` (#2236)

* Export adtype `AutoTapir`

* Update Project.toml

* Fix missing AutoTapir  (#2242)

* Update Essential.jl

* Update Project.toml

* Drop support for ADTypes 0.2 (#2243)

ADTypes 0.2 doesn't support AutoTapir yet.

* Optimization improvements (#2221)

* initial work on interface

* Improving the Optimization.jl interface, work in progress

* More work on Optimization.jl, still in progress

* Add docstrings to Optimisation.jl

* Fix OptimizationOptimJL version constraint

* Clean up optimisation TODO notes

* Relax OptimizationOptimJL version constraints

* Simplify optimization imports

* Remove commented out code

* Small improvements all over in optimisation

* Clean up of Optimisation tests

* Add a test for OptimizationBBO

* Add tests using OptimizationNLopt

* Rename/move the optimisation test files

The files for Optimisaton.jl and OptimInterface.jl were in the wrong
folders: One in `test/optimisation` the other in `test/ext`, but the
wrong way around.

* Relax compat bounds on OptimizationBBO and OptimizationNLopt

* Split a testset to test/optimisation/OptimisationCore.jl

* Import AbstractADType from ADTypes, not SciMLBase

* Fix Optimization.jl depwarning

* Fix seeds in more tests

* Merge OptimizationCore into Optimization

* In optimisation, rename init_value to initial_params

* Optimisation docstring improvements

* Code style adjustments in optimisation

* Qualify references in optimisation

* Simplify creation of ModeResults

* Qualified references in optimization tests

* Enforce line length in optimization

* Simplify optimisation exports

* Enforce line legth in Optim.jl interface

* Refactor away ModeEstimationProblem

* Style and docstring improvements for optimisation

* Add := test to optimisation tests.

* Clarify comment

* Simplify generate_initial_params

* Fix doc references

* Rename testsets

* Refactor check_success

* Make initial_params a kwarg

* Remove unnecessary type constrain on kwarg

* Fix broken reference in tests

* Fix bug in generate_initial_params

* Fix qualified references in optimisation tests

* Add hasstats checks to optimisation tests

* Extend OptimizationOptimJL compat to 0.3

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Change some `import`s to `using`

Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>

* Change <keyword arguments> to kwargs... in docstrings

* Add a two-argument method to OptimLogDensity as callable

---------

Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update Project.toml

* CompatHelper: bump compat for OptimizationOptimJL to 0.3 for package test, (keep existing compat) (#2246)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

---------

Co-authored-by: Markus Hauru <markus@mhauru.org>
Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

* Set fail-fast: false for CI test matrix

* Add a step to print matrix variables to tests Action

* Fix typo in tests Action

* ADTypes v0.2 compatibility for test restructuring (#2253)

* Restore compat with ADTypes v0.2. Make AutoTapir export conditional.

* Fix AutoTapir export in Essential.jl

---------

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
@mhauru mhauru mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torfjelde torfjelde torfjelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yebai @coveralls @devmotion @torfjelde