Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ADTypeCheckContext tests to a separate module #2383

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Oct 29, 2024

They were being run when test utils was imported, which was not ideal, and hard to leave out. Now they are in a module of their own.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (d2ea94a) to head (61e19f9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2383      +/-   ##
==========================================
- Coverage   86.45%   86.39%   -0.07%     
==========================================
  Files          22       22              
  Lines        1573     1573              
==========================================
- Hits         1360     1359       -1     
- Misses        213      214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, feel free to merge when CI passes :)

I wonder if we should have a merge queue for Turing as well?

@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11576558851

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 78.685%

Files with Coverage Reduction New Missed Lines %
ext/TuringOptimExt.jl 1 98.04%
Totals Coverage Status
Change from base Build 11573267768: -0.06%
Covered Lines: 1233
Relevant Lines: 1567

💛 - Coveralls

@mhauru mhauru merged commit 397d1a7 into master Oct 30, 2024
69 of 70 checks passed
@mhauru mhauru deleted the mhauru/adtypecheck-tests branch October 30, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants