Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored posts noticing #74

Open
saxamaphone69 opened this issue Jul 12, 2024 · 6 comments
Open

Restored posts noticing #74

saxamaphone69 opened this issue Jul 12, 2024 · 6 comments
Labels
polish Not necessary broken, but could be better

Comments

@saxamaphone69
Copy link

image

Noticed the hashlink still links to the archive, where as the quotelink gets updated accordingly.

Perhaps once deadlink is removed, resurrectedlink (or something) could be added? And posts that do get restored (and added back to the thread) get a postResurrected (or something) added either to the container/post itself (in addition to the strong.warning where it is currently). Would allow the option for additional styling by userstyles.

@TuxedoTako TuxedoTako added the polish Not necessary broken, but could be better label Jul 13, 2024
@leafstrat
Copy link

Sorry to post off-topic but I wanted to ask you, specifically @saxamaphone69 did you ever get something like this working?

Filter hiding cancels out highlighting
ccd0#3359

@saxamaphone69
Copy link
Author

@leafstrat Sadly, I couldn't wrap my head around it in the end. Perhaps since XT uses TypeScript instead of CoffeeScript it might invite others to try.

If you check the comments in that thread, someone did suggest a PR for it (albeit as a whole setting rather than per filter basis).

My PR was a poor attempt at copying Mayhem's original code (if you look at the commits from those 2 weeks he also converts any Reply and Thread to just Post, in addition to filter labelling). Since that commit, ccd0 had added options for General and type:filename+filesize+dimensions;, which confused me even more and breaks compatibility (along with the aforementioned Reply/Thread -> Post - though I'd argue this is a good change) between the versions.

If someone worked it out, I'm sure a lot of people would be appreciative. Even today, I noticed two threads matching a highlighting filter - but I have no idea which/don't want to check a dozens of filters to find the culprit. Being able to click the menu and see Label > Post highlighted due to "/blah/;", and clicking it then takes me to the line in the Filter settings, would be very handy.

image

If you're keen, please try!

TuxedoTako added a commit that referenced this issue Aug 4, 2024
- Added `from-archive` CSS class for posts restored from archives, and `from-archive-link` for quote links linking to
  them. For use in custom styles #74
@TuxedoTako
Copy link
Owner

Added from-archive and from-archive-link classes in 2.12.0. "resurrect" is the name of the function that restores posts if they got fetched from the archive before being loaded normally, so I didn't use that term in the CSS classes.

@saxamaphone69
Copy link
Author

Thanks for the classes.

As for the other part, the hashlink once restored still directs to the archive as opposed to the restored post. Hovering over the # in the middle post in the picture below.

image

As opposed to the expected behaviour:

image

@saxamaphone69
Copy link
Author

From an Anon, regarding Resurrected Posts

i want to hover a deleted post and peek what was deleted.
but in case it's some gay shit i could just move the mouse, instead right now the post is inlined.
a simple suboption for hover vs inline would be good.

@TuxedoTako
Copy link
Owner

Like I said in #18 (comment), the reason posts from external archives are inserted on hover is because a quirk in the interaction with the "Restore from archive" functionality. I'll need to make an "insert into thread but don't show until Restore from archive is used" function to do that. It's already complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Not necessary broken, but could be better
Projects
None yet
Development

No branches or pull requests

3 participants