Fix UnknownProperty being used for known properties #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the parser options IncludeUnknownDeclarations or AllowInvalidValues are set to true, StylesheetComposer will incorrectly use UnknownProperty for everything, even when the property name in question is a known one. Fix by first trying to create the property with the specified name and only falling back to UnknownProperty if the created property is null and one of IncludeUnknownDeclarations or AllowInvalidValues are set.
H1Gdev
added a commit
to H1Gdev/SVG
that referenced
this pull request
Sep 6, 2023
- Corresponds to TylerBrinks/ExCSS#152.
mrbean-bremen
pushed a commit
to svg-net/SVG
that referenced
this pull request
Sep 8, 2023
- corresponds to TylerBrinks/ExCSS#152.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parser options
IncludeUnknownDeclarationsorAllowInvalidValuesare set totrue,StylesheetComposerwill incorrectly useUnknownPropertyfor everything, even when the property name in question is a known one.Fixed by first trying to create the property with the specified name and only falling back to
UnknownPropertyif the created property is null and one ofIncludeUnknownDeclarationsorAllowInvalidValuesare set.The new test case is an example of something that was failing without this fix - despite
border-widthbeing a known property name, the parsed output would have this as anUnknownPropertyin the child list.