Fix animation name case #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TylerBrinks, any chance you can review it? |
| @@ -134,6 +134,15 @@ public static string ToIdentifier(this IEnumerable<Token> value) | |||
| return null; | |||
| } | |||
|
|
|||
| public static string ToIdentifierCaseInsensitive(this IEnumerable<Token> value) | |||
There was a problem hiding this comment.
If this PR will be considered to be merged, I would not name that method ToIdentifierCaseInsensitive but instead ToIdentifierCaseSensitive, because it actually does the opposite of what the current method name suggests.
So, it doesn't ignore the letter casing by converting it to all lower or upper case like the ToIdentifier method, it just returns the identifier string unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#168