Use option AllowInvalidSelectors to allow non-standard pseudo element selectors #170
Conversation
Also enable including debug symbols with source linking in the package.
|
Thank you @TylerBrinks for merging this. I will show you the lines (with comments from code review) that need adjustments for the build pipeline of this repo, because the original commit was also meant to fix the build pipeline for my fork. So, that it was able to automatically publish the NuGet package for my own NuGet space. |
| @@ -8,7 +8,7 @@ The goal of ExCSS is to make it easy to read and parse stylesheets into a friend | |||
| Version 4 is a move forward in framework support. The new version targets the latest version of .NET; Core 3.1 and 4.8. The API surface is the same as version 3, but will target the future-facing, unified .NET version including the upcoming .NET 5. Version 3 was rewritten from the ground up; version 4 makes full use of those enhancements plus new additions under development! This is the most advanced ExCSS parser to date. The parser has been rebuild to have better white spaces support as well as the ability to handle unknown rule sets in the ever-changing web and CSS landscape. | |||
|
|
|||
| # NuGet | |||
| [](https://www.nuget.org/packages/excss/) | |||
| [](https://www.nuget.org/packages/Anateus.ExCSS/) | |||
There was a problem hiding this comment.
Remove prefix Anateus. here, so revert this complete line.
| @@ -4,25 +4,41 @@ | |||
| <LangVersion>9.0</LangVersion> | |||
| <TargetFrameworks>net7.0;net6.0;netcoreapp3.1;net48;netstandard2.1;netstandard2.0</TargetFrameworks> | |||
| <AssemblyName>ExCSS</AssemblyName> | |||
| <PackageId>ExCSS</PackageId> | |||
| <PackageId>Anateus.ExCSS</PackageId> | |||
There was a problem hiding this comment.
Revert this line.
| <Title>ExCSS .NET Stylesheet Parser</Title> | ||
| <Authors>Tyler Brinks</Authors> | ||
| <Authors>Anateus,Tyler Brinks</Authors> |
There was a problem hiding this comment.
Revert this line or change order, if you want to mention me as author.
| <PackageReadmeFile>readme.md</PackageReadmeFile> | ||
| <RespositoryType>git</RespositoryType> | ||
| <RepositoryUrl>https://github.com/TylerBrinks/ExCSS</RepositoryUrl> | ||
| <PackageProjectUrl>https://github.com/matherm-aboehm/ExCSS</PackageProjectUrl> |
There was a problem hiding this comment.
Revert this line.
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageReadmeFile>readme.md</PackageReadmeFile> | ||
| <RespositoryType>git</RespositoryType> | ||
| <RepositoryUrl>https://github.com/matherm-aboehm/ExCSS</RepositoryUrl> |
There was a problem hiding this comment.
Revert this line.
|
Sorry about this confusion, I should have created a special branch only for this PR, where I could have corrected the above mentioned lines. But i was in a hurry, when I created this PR. |
Most CSS in production uses non-standard names for pseudo element selectors to get a more specific look and feel in most modern browsers, e.g. ::-webkit-inner-spin-button. Even your own test file
bootstrap.cssfor unit tests contains them.The current code base (Version 4.2.4) has no option to allow these non-standard names for the parser.
So, I created my own NuGet package for this feature.
To do this with GitHub Actions in my fork, I had to change the package information, so that it includes the right repository URLs and owner prefix for my own NuGet space.
You need to remove or edit commit a0e5991 from this PR to restore the previous build pipeline.
This fixes #69.