Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update half precision test cases to support Pytorch v1.12 #165

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Update half precision test cases to support Pytorch v1.12 #165

merged 2 commits into from
Aug 31, 2022

Conversation

mert-kurttutan
Copy link
Contributor

To resolve the issue #161

  • Explicitly dictate device=cpu in test cases to prevent mixed device when running on local device
  • Move half-precision test case into gpu_test.py since pytorch v1.12 does not
    support half precision on cpu

when running on local device

- Move half-precision test case into gpu_test.py since pytorch v1.12 does not
support half precision on cpu
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #165 (5585ea5) into main (c3216f6) will decrease coverage by 0.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   98.26%   97.39%   -0.87%     
==========================================
  Files           6        6              
  Lines         575      575              
==========================================
- Hits          565      560       -5     
- Misses         10       15       +5     
Impacted Files Coverage Δ
torchinfo/torchinfo.py 97.24% <0.00%> (-2.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TylerYep
Copy link
Owner

Can you also add the Pytorch 1.12 tests for this? In the .github folder:

matrix:
        python-version: ["3.7", "3.8", "3.9"]
        pytorch-version: ["1.4.0", "1.5.1", "1.6.0", "1.7.1", "1.8", "1.9", "1.10", "1.11"]  # add "1.12"

@TylerYep
Copy link
Owner

Looks good, thanks!

@TylerYep TylerYep changed the title Update test cases to resolve #161 Update half precision test cases to support Pytorch v1.12, resolves #161 Aug 31, 2022
@TylerYep TylerYep linked an issue Aug 31, 2022 that may be closed by this pull request
@TylerYep TylerYep changed the title Update half precision test cases to support Pytorch v1.12, resolves #161 Update half precision test cases to support Pytorch v1.12 Aug 31, 2022
@TylerYep TylerYep merged commit c77c7e7 into TylerYep:main Aug 31, 2022
@mert-kurttutan mert-kurttutan deleted the test_pytorch_v112 branch September 1, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed Cases When Testing with Pytorch v1.12
2 participants