condense error info

Type4ny-Project · Oct 8, 2024 · f62cd89 · f62cd89
1 parent b4d10aa
commit f62cd89
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/packages/backend/src/queue/QueueProcessorService.ts b/packages/backend/src/queue/QueueProcessorService.ts
@@ -127,29 +127,26 @@ export class QueueProcessorService implements OnApplicationShutdown {
 		this.logger = this.queueLoggerService.logger;
 
 		function renderError(e?: Error) {
+			// 何故かeがundefinedで来ることがある
+			if (!e) return '?';
+
 			if (e instanceof Bull.UnrecoverableError) {
 				return {
-					stack: undefined,
 					message: e.message,
 					name: 'Bull.UnrecoverableError',
 				};
-			} else if (e) { // 何故かeがundefinedで来ることがある
-				return {
-					stack: e.stack,
-					message: e.message,
-					name: e.name,
-				};
-			} else {
-				return {
-					stack: '?',
-					message: '?',
-					name: '?',
-				};
 			}
+
+			return {
+				stack: e.stack,
+				message: e.message,
+				name: e.name,
+			};
 		}
 
 		function renderJob(job?: Bull.Job) {
-			if (!job) return 'N/A';
+			if (!job) return '?';
+
 			return {
 				name: job.name,
 				info: getJobInfo(job),