Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Block update removing children when setting content #1103

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Sep 25, 2024

Closes #1101

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Sep 29, 2024 7:26pm
blocknote-website ✅ Ready (Inspect) Visit Preview Sep 29, 2024 7:26pm

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! However, as it's pretty core functionality, I think we should add more unit tests for all the different scenarios before merging this

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@YousefED YousefED merged commit ecddc65 into main Oct 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using editor.updateBlock while changing the content of the block deletes the children
2 participants