Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update remarkStringify config #841

Merged

Conversation

zaaakher
Copy link
Contributor

Fixes #834


For some reason, returning the text node within the remarkStringify handler option solved the issue with an extra backslash before the first bracket.

.use(remarkStringify, { handlers: { text: (node) => node.value } })

Before

339166596-baf435ae-a584-4e66-be80-64267319d125

After

blocknote-escape-checklist-solved

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:10am
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:10am

Copy link

vercel bot commented Jun 13, 2024

@zaaakher is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@matthewlipski
Copy link
Collaborator

Oh nice, this looks like an elegant fix:) I'll update the unit tests and then I think we can merge, thanks for your contribution!

@zaaakher
Copy link
Contributor Author

Thanks @matthewlipski . I will remember to run npm run test next time 😁

@TheMikeyRoss
Copy link

Nice thanks @zaaakher , would this be included in 0.14.2 ?

@zaaakher
Copy link
Contributor Author

Nice thanks @zaaakher , would this be included in 0.14.2 ?

Yes I believe so. Although it's up to the maintainers.

@matthewlipski matthewlipski merged commit bc2b334 into TypeCellOS:main Jun 17, 2024
4 checks passed
@zaaakher zaaakher deleted the fix/extra-backslash-before-brackets branch July 14, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replaceBlocks is removing the space between brackets for checklists
3 participants