Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit detect broken #182

Closed
basarat opened this issue Mar 10, 2015 · 4 comments
Closed

Emit detect broken #182

basarat opened this issue Mar 10, 2015 · 4 comments

Comments

@basarat
Copy link
Member

basarat commented Mar 10, 2015

Previously we had:

success : output.emitOutputStatus === ts.EmitReturnStatus.Succeeded;
emitOnly: !success && outputFiles.length

Now getEmitOutput only returns :

interface EmitOutput {
    outputFiles: OutputFile[];
    emitSkipped: boolean;
}

With only emitSkipped we don't know if it was a complete success i.e. a semantically valid emit or just a bland emit.

@basarat basarat added this to the TypeScript 1.5 milestone Mar 10, 2015
@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

refs #179 (comment)

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

refs microsoft/TypeScript#2289

@DanielRosenwasser
Copy link

You can use the --noEmitOnError flag for this, even though the message says it only pertains to type checking.

@basarat
Copy link
Member Author

basarat commented Mar 11, 2015

@DanielRosenwasser I still want to get an emit. So did this : 02622f9#diff-578ff651be440fee29ecfe22d52e81a4L41

@basarat basarat closed this as completed Mar 11, 2015
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants