Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 1.5 #179

Merged
merged 36 commits into from
Mar 17, 2015
Merged

Typescript 1.5 #179

merged 36 commits into from
Mar 17, 2015

Conversation

basarat
Copy link
Member

@basarat basarat commented Mar 10, 2015

Things to do. An ever updating list:

  • Watch the filesGlob | files for changes. We only watch "changes" not "addition / deletion" for now.

@csnover
Copy link
Member

csnover commented Mar 10, 2015

Yes, there is no version of TypeScript available anywhere that has the necessary patches to make ES6 import/export work with declarations (microsoft/TypeScript#2139), so what’s committed to my branch is a custom build with that patch applied. microsoft/TypeScript#2197 was also necessary in that build but has since been merged, so microsoft/TypeScript#2139 is the only one I’m waiting for until getting a new “official” build. Watch microsoft/TypeScript#2242 for updates!

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

^ the reply was for this diff from npm install

image

@csnover alright. So I will not run npm install ❤️ . I'll be doing new fixes in this branch just because I can't live without let anymore.

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

@csnover I suspect the reference bugs you are getting a specific to 1.5. Cannot do build ctrl+shift+b anymore. Fails with :

image

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

We are not doing fs checks for references. Only doing it for imports. I'll fix it tomorrow. Off for now.

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

@csnover @park9140 I am feeling that having stuff that is not referenced from files in tsconfig.json is always going to result in tricky error cases : #180 and #45

I don't see a graceful way of handling this. Any ideas?

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

@csnover sorry #180 was fixable ❤️

Still don't have an answer for what to do with #45 though.

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

UPDATE: bug has been fixed

A bug for me :
image this should not happen.

@park9140
Copy link
Contributor

@basarat, I was planning on using https://www.npmjs.com/package/vinyl-fs in order to simplify this scenario. You can populate a vinyl stream with the glob patterns and it will keep itself updated when you use the watch methodology.

@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

Having a quick look I think it's meaning of glob is different : order is significant. I am sure the gulp users are used to it but that is not what we promised with our filesGlob. Our is that it must match all patterns.

I am leaning towards https://www.npmjs.com/package/gaze simply watching our glob and only updating our text if the file isn't open in the editor (which the child can query)

@basarat
Copy link
Member Author

basarat commented Mar 11, 2015

I can definitely feel the speed up ❤️

@basarat
Copy link
Member Author

basarat commented Mar 13, 2015

@csnover is it okay if I merge and publish this a new major version?

There are lot of good performance fixes here that I'd like to get in the hands of everyone. Its been working like a charm for me.

@csnover
Copy link
Member

csnover commented Mar 13, 2015

TS team was hoping to have microsoft/TypeScript#2139 landed by end of the week so can we maybe wait until Monday to see if that happens? Otherwise I don’t think I have any major objections.

@basarat
Copy link
Member Author

basarat commented Mar 13, 2015

Otherwise I don’t think I have any major objections.

Thanks I'll wait till monday ❤️

@basarat
Copy link
Member Author

basarat commented Mar 17, 2015

I've been using this over the weekend as well as on Monday. Its much better than what we have on master so publishing as a major version.

basarat added a commit that referenced this pull request Mar 17, 2015
@basarat basarat merged commit 4d3f427 into master Mar 17, 2015
@basarat basarat deleted the typescript-1.5 branch March 17, 2015 01:27
@basarat
Copy link
Member Author

basarat commented Mar 17, 2015

I have merged into master. That's a good thing as I can ask people to just use master for the latest fixes. However I'm not going to publish till we have a valid package.json.

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants