-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.2.10+ crash when using workspaces and project references #630
Comments
Thank you! @lnewson, I can confirm that the issue is with the latest version 6.2.10 or v7 alpha, using 6.2.9 solved it for now |
Thanks for the report and investigation! 👍🏻 I will take a look soon :) |
In the situation, when there were already some files built in the real fs, controlled typescript system returned true for fileExists call on initial run and false on subsequent calls causing assertion in TypeScript to fail. ✅ Closes: #630
In the situation, when there were already some files built in the real fs, controlled typescript system returned true for fileExists call on initial run and false on subsequent calls causing assertion in TypeScript to fail. ✅ Closes: #630
In the situation, when there were already some files built in the real fs, controlled typescript system returned true for fileExists call on initial run and false on subsequent calls causing assertion in TypeScript to fail. ✅ Closes: #630
🎉 This issue has been resolved in version 6.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @piotr-oles! 🏆 |
🎉 This issue has been resolved in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Current behavior
When using version 6.2.10 or above and a workspace with project references, an exception is thrown and the plugin crashes:
I did some investigation into this and the cause appears to be the memfs changes done in 6.2.10, as it appears to assume that after the initial run the files will always be written into the memory filesystem for every file/artifact in the bundle. However, this is not the case for project references, as it'll only rebuild the projects that have changed. This then means that files in unchanged projects/packages aren't in the memory based filesystem and it says they don't exist when calling
fileExists
. In addition to this, since the symlink isn't in the artifacts list, it uses the real filesystem which does resolve and is why it appears to think the symlink points to a non-existent file.Current workarounds I'm aware of:
mode
towrite-references
so the memory based filesystem is not used.Expected behavior
No error should occur, as the symlinked files exist in the real filesystem.
Steps to reproduce the issue
I've created a reproduction repo here and the steps are in the README: https://github.com/lnewson/fork-ts-checker-bug
Environment
The text was updated successfully, but these errors were encountered: