-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nativescript-vue-template-compiler support (#354) #355
feat: add nativescript-vue-template-compiler support (#354) #355
Conversation
I don't have much experience with yarn. |
I believe you've changed the package.json but you didn't do so with yarn and so the yarn.lock file wasn't regenerated. You're going to need to use yarn to regenerate the lock file. Simply executing |
543dd12
to
6ece55e
Compare
@johnnyreilly |
In holiday right now - will check soon. Thanks! |
Looks pretty good to me; though I'm mindful I'm not too knowledgeable about Vue. cc @yyx990803 in case there's any views on this? (I think this plugin is used in the Vue CLI so thought I'd give a heads up) |
6ece55e
to
aafe8cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this. If @piotr-oles / @phryneas are cool with this I'm fine with this shipping.
It would be great to get some Vue user opinion in the mix too
Code-wise, this looks good to me. But I'm not 100% happy with the integration tests, as this doesn't test if the actual compilation happens with Maybe duplicate the whole test suite with |
aafe8cd
to
443c74d
Compare
Good idea. in progress right now |
443c74d
to
818196d
Compare
@johnnyreilly, @phryneas, @piotr-oles |
818196d
to
5aa348e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some things I saw at first glance - have to give this a better review later, or tomorrow.
* feat: add nativescript-vue-template-compiler support * test: add vue related unit and integrations tests * docs: add information about nativescript-vue-template-compiler support
5aa348e
to
818aa58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR for #354
feat: add nativescript-vue-template-compiler support
test: add vue related unit and integrations tests
docs: add information about nativescript-vue-template-compiler support