Additional error summary #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yup, its designed to make sure that the task fails (on your build server) if there is a compile error :) |
|
@nycdotnet sweet! thanks! |
|
pushed to npm in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some summary info to the log. If there are no detected errors, nothing is logged. However, in the case of compiler, syntax, or type errors, some additional stuff is shown. I made it so the double chevron shows as red or green based on the presence of only non-emit-preventing type warnings.
I think that this could be further improved by summarizing type warnings per file. If it seems a bit silly that there might ever be 172 type errors across multiple files, this is actually very plausible if you've either just implemented TypeScript from plain JS or else if you've just turned on no implicit any.
Please let me know what you think.
Note: the ts:fail task is failing when I build this. I'm assuming that's ok?