Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate declaration files for js files if allowJs is set to true #1483

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Generate declaration files for js files if allowJs is set to true #1483

merged 4 commits into from
Jun 22, 2022

Conversation

mvilliger
Copy link
Contributor

Fixes #1260.

hediet and others added 2 commits June 22, 2022 11:45
@hediet @mvilliger
Fixes #1260 by generating declaration files for js files if allowJs i…
4cf4a00 
…s set to true.
@mvilliger
Fix declarationOutputAllowJs test
dca8aac 
Update expected test output for 4.7 and
stabilize expectation to be OS independent.
@johnnyreilly
Copy link
Member

This is great! Thanks 👍

Please could you update the package.json and the CHANGELOG.md and let's ship!

@mvilliger
Copy link
Contributor Author

Of course. Verion 9.3.1?

@johnnyreilly
Copy link
Member

Sure!

johnnyreilly
johnnyreilly reviewed Jun 22, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mvilliger @johnnyreilly
Update CHANGELOG.md
a5e9bbd 
Co-authored-by: John Reilly <johnny_reilly@hotmail.com>
@johnnyreilly johnnyreilly merged commit b4b0363 into TypeStrong:main Jun 22, 2022
@mvilliger mvilliger mentioned this pull request Jun 22, 2022
Closed
@mvilliger mvilliger deleted the features/allowJsDeclarationSupport branch June 22, 2022 14:48
@cssecautomation cssecautomation mentioned this pull request Oct 28, 2022
Closed
@X-oss-byte X-oss-byte mentioned this pull request May 24, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
This was referenced Sep 6, 2024
Open
Open
This was referenced Sep 16, 2024
Open
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyreilly johnnyreilly johnnyreilly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No .d.ts Declaration Files for JS Files Are Emitted (allowJs: true)
3 participants
@mvilliger @johnnyreilly @hediet