Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter unsupported signals on Windows (#513) #514

Closed
wants to merge 1 commit into from
Closed

Filter unsupported signals on Windows (#513) #514

wants to merge 1 commit into from

Conversation

coreh
Copy link

@coreh coreh commented Jan 17, 2018

This fixes issue #513.

From https://nodejs.org/api/process.html#process_signal_events:

Note: Windows does not support sending signals, but Node.js offers some emulation with process.kill(), and subprocess.kill(). Sending signal 0 can be used to test for the existence of a process. Sending SIGINT, SIGTERM, and SIGKILL cause the unconditional termination of the target process.

@coveralls
Copy link

coveralls commented Jan 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 77.427% when pulling 46f3910 on coreh:fix/enosys-on-windows into d5a941c on TypeStrong:master.

@blakeembrey
Copy link
Member

Killed subprocesses altogether to save my sanity. Closed with #536.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreh @coveralls @blakeembrey