Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --stack-trace-limit to known flags #533

Closed
wants to merge 1 commit into from

Conversation

Codesleuth
Copy link

I use ts-node to run TypeScript tests and often get truncated stack traces in the output. This PR simply adds this as a recognised flag to be passed to node.

See:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.427% when pulling 9806626 on Codesleuth:patch-1 into d5a941c on TypeStrong:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.427% when pulling 9806626 on Codesleuth:patch-1 into d5a941c on TypeStrong:master.

@coveralls
Copy link

coveralls commented Feb 14, 2018

Coverage Status

Coverage remained the same at 77.427% when pulling 9806626 on Codesleuth:patch-1 into d5a941c on TypeStrong:master.

@blakeembrey
Copy link
Member

Closing with #536. I recommend using node -r ts-node/register instead for node.js flags.

@Codesleuth
Copy link
Author

OK, that's fine. However, with specifying ts-node/register as a pre-loaded module, how can I pass the options I would have passed previously to the ts-node entry point, such as -P myproject?

(note that I am looking specifically to avoid using environment variables)

@Codesleuth Codesleuth deleted the patch-1 branch February 20, 2018 16:08
@blakeembrey
Copy link
Member

I'm not sure there is a way unfortunately. It's a trade off and I decided to make the trade off for project maintenance reasons. Dealing with the many flag additions, changes and bugs related to spawning child processes took too much time for myself to triage. If you come up with a solution let me know! I think the solution would live in node.js somehow supporting sub-args like node -r [ts-node --project .].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants