feat(golint): Update default go version to v1.19.11 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmlanger
commented
Aug 3, 2023
xespona
approved these changes
Aug 3, 2023
jordiroig-tf
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current go versions we specify as default versions for the linter are so very old that they are not even supported any longer. Updating it to golang v1.19, because that is the oldest supported version.
Note that these are the default versions, if there is any case that a service needs to use an older go version, one can overwrite the defaults like this:
(example: https://github.com/Typeform/forms-api/blob/b9383c8234dad5a8c19478ed5e01de5d2a0c5eef/.github/workflows/lint.yaml#L12)
See also https://www.notion.so/typeform/Use-supported-runtime-versions-4336ec1006ca4a9da53c6f57e914296e#fce1c1bce18b4e61b834440907dc0ba9 for some additional information and motivation.
See also https://typeform.slack.com/archives/CPKBRDQPQ/p1691056721928979 for the discussion that triggered this update now.