[NOJIRA-123] fix(comment-deploy-link): do not break when a single quote is on title #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the GitHub Action so that it prevents that a pull request title containing the ` character breaks. This is fixed by reading these values (branch and pr title) as strings from environment variables instead of interpolating these in the script, as recommented by https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable NOJIRA-123
davidsalvador-tf
approved these changes
Sep 4, 2023
gomezjdaniel
changed the title
gomezjdaniel
deleted the
NOJIRA123-fix-comment-deploy-link-single-quote
branch
|
@davidsalvador-tf AFAIK a new release has to be done, right? |
|
@gomezjdaniel yes, I just ran it https://github.com/Typeform/.github/actions/runs/6232837964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the GitHub Action so that it prevents that a pull request title containing the ` character breaks.
This is fixed by reading these values (branch and pr title) as strings from environment variables instead of interpolating these in the script, as recommented by
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
This screenshot belongs to this failed job
