feat(PR-41): add a shared CI standard checks workflow #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macabu
reviewed
Jan 8, 2024
| jobs: | ||
| ci-standard-checks: | ||
| runs-on: | ||
| - ubuntu-latest |
There was a problem hiding this comment.
:chefs-kiss: This is the most important part of the change, now using GH hosted runners for this workflow
Co-authored-by: Matheus Macabu <macabu@users.noreply.github.com>
zdenekkostal
previously approved these changes
Jan 8, 2024
|
The value used for |
davidsalvador-tf
approved these changes
Jan 10, 2024
| - name: CI Standard Checks | ||
| uses: Typeform/ci-standard-checks@v1 | ||
| with: | ||
| githubToken: ${{ secrets.GH_TOKEN }} |
There was a problem hiding this comment.
I think that for this use case we can use the token with minimum privileges that is generated per repository (GITHUB_TOKEN) instead of this Organization wide secret GH_TOKEN which corresponds to a PAT from a user with lots of privileges. See GitHub's security hardening guidelines.
Suggested change
| githubToken: ${{ secrets.GH_TOKEN }} | |
| githubToken: ${{ secrets.GITHUB_TOKEN }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new workflow for CI standard checks. We will use it to use the 50k free minutes we have with Github.
https://typeform.slack.com/archives/CCWDN8ASJ/p1704726455798989