Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an exeption for catalog-info.yaml files #63

Closed
wants to merge 1 commit into from

Conversation

cesarlugoe
Copy link

Testing a bulk PR for adding this file in forms-api, breaks the build because of a false positive.

Because we are going to do a bulk PR adding this file to all repositories, and this file will never need have any kind of secrets, I thought it would be a good idea to skip it.

This file will be added automatically in all repositories, hence the idea

This is the Action prompt
CleanShot 2023-07-31 at 18 03 12@2x

This is the line giving the false positive:
https://github.com/Typeform/forms-api/blob/40a327bdaf24a956fc1e51c46b6edea645812a5e/catalog-info.yaml#L21

@cesarlugoe cesarlugoe requested a review from a team as a code owner July 31, 2023 16:04
@cesarlugoe cesarlugoe self-assigned this Jul 31, 2023
@davidsalvador-tf
Copy link
Contributor

Hi @cesarlugoe, if possible I would try to avoid excluding entire files that are not auto generated (e.g. manifest lock files) or not subject to be changed by the developer (e.g. images or binaries). Today this catalog-info.yaml might not include secrets but this can change over time and there's the risk about forgetting to change this.

What about adding #gitleaks:allow at the end of the line with the false positive (more info)?

@cesarlugoe
Copy link
Author

Yes, that works @davidsalvador-tf easy fix. Thank you!

@cesarlugoe cesarlugoe closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants