-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base content style overrides #2
Conversation
…eadme; per-pg consistency fixes
…ith floating quotation mark
… display heading classes
… consistency between perceived font sizes between each font family
…ble-inverse stripe and active background colors
… Chronicle Text instead of Chronicle Display; updated font size overrides as needed
…removed references to fallback font usage for now
…te documentation area
…nd add new variants
@@ -91,12 +91,24 @@ | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of modifying the bootstrap _variables.scss would it make sense to create a _ucf_variables.scss included after the _variables.scss and overriding the bootstrap variables? This would make updating bootstrap easier especially since it is still alpha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make much more sense, but due to the way that sass variable inheritance works, it ends up being easier for us to just maintain our own custom copy of _variables.scss. Doing so makes sure that:
a) we always have access to Bootstrap variables when adding or modifying other variables (e.g. we don't run into issues with trying to use variables that aren't yet defined), and
b) changes we make to Bootstrap-specific variables cascade into other dependent variables.
Bootstrap actually started having custom-build users define a _custom.scss file that imported after Bootstrap's _variables.scss in an earlier alpha version, but ended up reverting the change due to variable overrides no longer working properly.
This branch gives us a base set of content-related styles for Athena. It's starting to look much less Bootstrappy already, yay!
The diff is fairly long, but the main takeaways are bulleted below:
Tables:
Type:
I'm using rem units here to match Bootstrap; there's some discussion on their reasoning for doing so here and here. One thing in particular to note: the responsive font size overrides added in this branch are all relative to the root font size--which is generally 16px--NOT to the font size of
body
. So, all rem-unit values are going to be relative to 16px (usually, depending on the browser/system). I opted to not utilize a responsive typography method (e.g. https://v4-alpha.getbootstrap.com/content/typography/#responsive-typography) because, despite the font sizes of headings, blockquotes, etc scaling up with the document font size, they tend to still need some breakpoint-specific adjustments, and adjusting them in relation to the current browser size adds an extra layer of complexity (compared to always adjusting sizes relative to ~16px).Dividers:
Other: