feat: Update the instructor notes for Fall 2024 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
dpshelio
approved these changes
Nov 4, 2024
| {{ site.remote.prompt }} cd amdahl | ||
| {{ site.remote.prompt }} wget -O amdahl.tar.gz https://github.com/hpc-carpentry/amdahl/tarball/main | ||
| {{ site.remote.prompt }} tar -xvzf amdahl.tar.gz | ||
| {{ site.remote.prompt }} cd hpc-carpentry-amdahl-46c9b4b |
There was a problem hiding this comment.
Wouldn't the hash at the end change every time amdahl's repository gets updated? It hasn't change in two years though....
| @@ -113,7 +113,7 @@ get your job dispatched earlier. | |||
| > > finish within 2 minutes: | |||
| > > | |||
| > > ``` | |||
| > > {{ site.sched.comment }} {{ site.sched.flag.time }}{% if site.sched.name == "Slurm" %} {% else %}={% endif %}00:02:00 | |||
| > > {{ site.sched.comment }} {{ site.sched.flag.time }}00:02:00 | |||
There was a problem hiding this comment.
Suggested change
| > > {{ site.sched.comment }} {{ site.sched.flag.time }}00:02:00 | |
| > > {{ site.sched.comment }} {{ site.sched.flag.time }}{% if site.sched.name == "Slurm" or "SGE" %} {% else %}={% endif %}00:02:00 |
I believe this may work, but if we are going to diverge and then adopt what they have for a Slurm site in the future, then fine.
|
|
||
| ``` | ||
| ~/.matlab is a symbolic link pointing to /home/yourUsername/Scratch/.matlab | ||
| ~/.matlab is a symbolic link pointing to /home/ccaech0/Scratch/.matlab |
There was a problem hiding this comment.
Suggested change
| ~/.matlab is a symbolic link pointing to /home/ccaech0/Scratch/.matlab | |
| ~/.matlab is a symbolic link pointing to /home/yourUsername/Scratch/.matlab |
| @@ -18,7 +18,7 @@ | |||
| > > | |||
| > > ``` | |||
| > > {{ site.remote.bash_shebang }} | |||
| > > #SGE -l 00:00:30 | |||
| > > {{ site.sched.comment }} {{ site.sched.time}}00:00:30 | |||
There was a problem hiding this comment.
Suggested change
| > > {{ site.sched.comment }} {{ site.sched.time}}00:00:30 | |
| > > {{ site.sched.comment }} {{ site.sched.flag.time}}00:00:30 |
though liquid may work out if is one of its childs.
|
Just noting I've also looked through these, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of updates by file:
_config.ymlRemove a duplicate variable and replace the node name with one that will play nicely withqhost_episodes/*Minor changes to correct the job scripts- Ideally some variables would be changed/added upstream but SGE is not planned to be supported in the future and there isn't a simpler way to do these._episodes/17-parallel.mdAdd instructions for loading the python3 module- ideally this should be a new snippet but they're hoping to replace snippets with something else when the upstream lesson gets overhauled.modules/software-dependencies.snipNew modules now loads dependancies automatically in most cases. Yay!modules/wrong-gcc-version.snipNew modules lets us streamline this example. Yay!scheduler/print-sched-variables.snipCorrect SGE job scripts for the new environment variables lesson