Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code scanning alerts #433

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Code scanning alerts #433

merged 3 commits into from
Dec 4, 2024

Conversation

DavidPCoster
Copy link
Collaborator

This was left from last time, I think ...

@djgroen
Copy link
Contributor

djgroen commented Dec 4, 2024

Rerunning tests before my review :).

djgroen
djgroen approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@djgroen djgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple change that doesn't break the code according to the tests.

@wedeling wedeling self-assigned this Dec 4, 2024
wedeling
wedeling reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@wedeling wedeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@djgroen djgroen merged commit c896832 into dev Dec 4, 2024
10 checks passed
@djgroen djgroen deleted the code_scanning_alerts branch December 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wedeling wedeling wedeling approved these changes

@djgroen djgroen djgroen approved these changes

Assignees

@wedeling wedeling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidPCoster @djgroen @wedeling @JonMcCullough