Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding introduction to citing author and citing work #478

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Sep 26, 2024

closes #383

@acholyn acholyn requested a review from tcouch September 26, 2024 13:04
Copy link
Collaborator

@tcouch tcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding or updating an introduction on a citing_work or citing_author, if it includes a mention of a bibliography item, you get the following error:

File "/app/rard/utils/basemodel.py", line 319, in link_bibliography_mentions
     for ant in antiquarians:
UnboundLocalError: local variable 'antiquarians' referenced before assignment

We can't really assign an antiquarian to a citing author or citing work, but we would like to link bibliography items in the same way. We'll have to expand the link_bibliography_mentions method to handle this.

src/rard/utils/basemodel.py Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the Antiquarian detail page, there's a htmx trigger on the bibliography item list which refreshes it when the introduction is updated. It just means you get to see the updated bibliography without having to refresh the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding text boxes to citing authors and citing author works
2 participants