-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
further model testing #8
further model testing #8
Conversation
What are the differences between the two metrics, MAE and RMSE? How do they relate to precision and accuracy? How can we explain this in layman's terms, apply it directly to Helios, and make real world decisions from this? |
74327db
to
e02a582
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small changes.
Great conclusion.
analysis/furtherModelTesting.ipynb
Outdated
"\n", | ||
"X_train, X_test, y_train, y_test = train_test_split(X, y, test_size=global_test_size, random_state=global_random_state)\n", | ||
"# Define the parameter grid for Random Forest\n", | ||
"param_grid_rf = {\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tell me how many times this model will be trained with this size of param_grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this change if we also wanted to use Cross validation of say... 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the model is trained once for each combination, so it's 3x4x3x3=108 times. cross validation of 5 means we would train 5 times per combination so 5x108= 540. Is this too much?
Also I was hoping you would do the hyper parameter tuning optimizations in I feel more comfortable reviewing smaller PRs |
1a04102
to
499c367
Compare
499c367
to
697deae
Compare
trained models on KNN, Decision Trees, Random Forests, and Gradient Boosting, all with and without Cross Validation.