-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2.dev4] Utilities for merging tables #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
smmaurer
changed the title
Utilities for merging tables
[0.2.dev4] Utilities for merging tables
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds utilities to perform merges using implicit join keys (column names that match index names) instead of requiring Orca broadcasts. See issues #78 and #100.
New utilities
utils.validate_table()
utils.validate_all_tables()
utils.merge_tables()
The validation tools check that tables conform to the new stricter spec: unique index or multi-index values, no duplicate index/column names within a table. Also prints some stats to indicate whether columns that match index names of other tables make sense as join keys.
The merge tool replaces
orca.merge_tables()
and is simpler and more deterministic. It also supports merging on multi-indexes (useful for interaction terms and sampling weights), which orca doesn't.Other changes
utils.get_data()
to use the new merge tool instead of Orca'sBinaryLogitStep
andOLSRegressionStep
) to useutils.get_data()
, removing any reliance on broadcasts(The Pandas API is moving toward allowing users to refer to index and non-index columns interchangeably by name, which is nice: it's easier, and aligns better with other data formats. Version 0.23 allows specification of merge keys by name whether or not they're indexes.)
Versioning
0.2.dev4
To do before merging
utils.merge_tables()
utils.get_data()
to use new merge tool