Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert component #313

Closed
Richard592 opened this issue Nov 16, 2021 · 5 comments
Closed

Alert component #313

Richard592 opened this issue Nov 16, 2021 · 5 comments

Comments

@Richard592
Copy link

Hi, the Alert component uses non-standard colours which need adding to the component details somewhere, They are:

.panel-border-wide.alert-default {
border-color: #2b8cc4;
background-color: #dbeff9;
}
.panel-border-wide.alert-success {
border-color: #28a197;
background-color: #c6ece9;
}
.panel-border-wide.alert-error {
border-color: #c42b2b;
background-color: #f3dede;
}

Thanks.

@Sarraounia
Copy link
Contributor

Sarraounia commented Feb 28, 2022

@Richard592 do you know if this was ever added to the design system? I want to add some new text to the Alert component to help content designers write content for alerts. If your suggestion hasn't been added yet, probably makes sense to put both these updates through together.

@Richard592
Copy link
Author

@Sarraounia it looks like it hasn't been implemented, just judging by it still being unassigned. Happy for you to add additional criteria to this open issue. How it gets prioritised I don't know though. If you need it prioritising maybe include a nudge to Laurence Piercy as he is fielding GitHub contributions (I think).

@Sarraounia
Copy link
Contributor

@Richard592 I've got my content ready now for the Alert page. I am on the design system working group so will liaise with Laurence and the team about this update.

What are your thoughts on how to communicate the non-standard colours? I have an idea but it's probably best if we have a quick chat about it. I can't tell who you are from your GitHub username so if you can write to me on Slack or send me an email, that would be great!

@Richard592
Copy link
Author

Richard592 commented Mar 31, 2022 via email

@anandamaryon-gov
Copy link

Just to loop into this issue to mention that the current colours used on the alert backgrounds don't allow enough contrast when using links within alerts. So if the colours are being looked at, this would be good to consider.

@UKHomeOffice UKHomeOffice locked and limited conversation to collaborators Apr 7, 2022
@Sarraounia Sarraounia converted this issue into discussion #358 Apr 7, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants