-
Notifications
You must be signed in to change notification settings - Fork 22
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert component #313
Comments
@Richard592 do you know if this was ever added to the design system? I want to add some new text to the Alert component to help content designers write content for alerts. If your suggestion hasn't been added yet, probably makes sense to put both these updates through together. |
@Sarraounia it looks like it hasn't been implemented, just judging by it still being unassigned. Happy for you to add additional criteria to this open issue. How it gets prioritised I don't know though. If you need it prioritising maybe include a nudge to Laurence Piercy as he is fielding GitHub contributions (I think). |
@Richard592 I've got my content ready now for the Alert page. I am on the design system working group so will liaise with Laurence and the team about this update. What are your thoughts on how to communicate the non-standard colours? I have an idea but it's probably best if we have a quick chat about it. I can't tell who you are from your GitHub username so if you can write to me on Slack or send me an email, that would be great! |
Hi Ounie!!
Turns out it is me that contributed to the Alert component on GitHub. I haven't been receiving any updates from gitHub, until two minutes ago.
Laurence is still the best person to contact about it though. But happy to have a chat about it to see if i can help at all.
Richard Chilver
Senior Service Designer
Migration and Borders Technology
Home Office Data, Digital and Technology
Sheffield Delivery Centre<https://collaboration.homeoffice.gov.uk/display/DH/Sheffield+Delivery+Centre>
Vulcan House Steel
4-6 Millsands
Sheffield
S3 8NU
HO Digital Data and Technology Strategy<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.gov.uk%2Fgovernment%2Fpublications%2Fhome-office-digital-data-and-technology-strategy-2024%2Fhome-office-digital-data-and-technology-strategy-2024&data=04%7C01%7CRichard.Chilver%40digital.homeoffice.gov.uk%7Ca08dfbb7e35e472f8afe08d9469c1b97%7C90a6982e16354aa087a6d5d63c7bc66e%7C0%7C0%7C637618458554297059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=hInrXZfERg0DOYo69KO1nIwN8rhwOndHJeAKfXQYxs8%3D&reserved=0>
…________________________________
From: Sarraounia Christianson ***@***.***>
Sent: 31 March 2022 09:52
To: UKHomeOffice/design-system ***@***.***>
Cc: Richard Chilver ***@***.***>; Mention ***@***.***>
Subject: Re: [UKHomeOffice/design-system] Alert component (Issue #313)
@Richard592<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRichard592&data=04%7C01%7Crichard.chilver%40digital.homeoffice.gov.uk%7C6427f63626bc4fd1774c08da12f3bfa7%7C90a6982e16354aa087a6d5d63c7bc66e%7C0%7C0%7C637843135356822470%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=fYqZU4DoSyOxPdZZoGVOlIVUa5rX2eKpRaqmwSWSdDc%3D&reserved=0> I've got my content ready now for the Alert page. I am on the design system working group so will liaise with Laurence and the team about this update.
What are your thoughts on how to communicate the non-standard colours? I have an idea but it's probably best if we have a quick chat about it. I can't tell who you are from your GitHub username so if you can write to me on Slack or send me an email, that would be great!
—
Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUKHomeOffice%2Fdesign-system%2Fissues%2F313%23issuecomment-1084284180&data=04%7C01%7Crichard.chilver%40digital.homeoffice.gov.uk%7C6427f63626bc4fd1774c08da12f3bfa7%7C90a6982e16354aa087a6d5d63c7bc66e%7C0%7C0%7C637843135356822470%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=SwnGjOeLvTBsVcMDdjwojEplHm0TVi9gxQ5gCm%2FItgw%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUHLGQHGBTLOBS5GVDZZKWTVCVRTXANCNFSM5IEHB7TA&data=04%7C01%7Crichard.chilver%40digital.homeoffice.gov.uk%7C6427f63626bc4fd1774c08da12f3bfa7%7C90a6982e16354aa087a6d5d63c7bc66e%7C0%7C0%7C637843135356822470%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jb9%2BYpKlBHBbmR50YPq%2Bh13Llw0zWBpbczaP8hTxsII%3D&reserved=0>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Please ensure that any communication with the Home Office is via an official account ending with digital.homeoffice.gov.uk, homeoffice.gov.uk or homeoffice.gsi.gov.uk. This email and any files transmitted with it are private and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please return it to the address it came from telling them it is not for you and then delete it from your system. Communications via the digital.homeoffice.gov.uk domain may be automatically logged, monitored and/or recorded for legal purposes. This email message has been swept for computer viruses.
|
Just to loop into this issue to mention that the current colours used on the alert backgrounds don't allow enough contrast when using links within alerts. So if the colours are being looked at, this would be good to consider. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hi, the Alert component uses non-standard colours which need adding to the component details somewhere, They are:
.panel-border-wide.alert-default {
border-color: #2b8cc4;
background-color: #dbeff9;
}
.panel-border-wide.alert-success {
border-color: #28a197;
background-color: #c6ece9;
}
.panel-border-wide.alert-error {
border-color: #c42b2b;
background-color: #f3dede;
}
Thanks.
The text was updated successfully, but these errors were encountered: